Allow the sidecar to sample from a list of prefill host ports #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The configuration this allows is |
smarterclayton
force-pushed
the
enable_prefiller_sampling
branch
from
fae0dcf to
1143dac
Compare
In some benchmarking and test environments dynamic prefill selection
may be difficult and random selection among a set of hosts is
sufficient.
Add a new `--enable-prefiller-sampling` flag that instructs the
sidecar to select a random prefill host from the provided list
instead of the first one. Make the behavior opt-in to prevent
users from accidentally depending on the new behavior, and
keep the existing default behavior (first header value) consistent.
E.g.:
curl -H 'x-prefiller-host-port: server1:8000` -H 'x-prefiller-host-port: server2:8000'
will randomly choose one of the two values.
Signed-off-by: Clayton Coleman <[email protected]>
smarterclayton
force-pushed
the
enable_prefiller_sampling
branch
from
1143dac to
b49f6e3
Compare
|
@smarterclayton as we've moved the routing sidecar code into llm-d-inference-scheduler, could you kindly close the PR here and more move the code over to the new repo if needed? |
|
Moved to llm-d/llm-d-inference-scheduler#404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some benchmarking and test environments dynamic prefill selection may be difficult and random selection among a set of hosts is sufficient.
Add a new
--enable-prefiller-samplingflag that instructs the sidecar to select a random prefill host from the provided list instead of the first one. Make the behavior opt-in to prevent users from accidentally depending on the new behavior, and keep the existing default behavior (first header value) consistent.E.g.:
will randomly choose one of the two values.
This allows static test environments to use multiple hardcoded hosts for testing. A load balancer may still be desirable, but I am chasing an issue where using a load balanced prefiller group does not result in the correct serving behavior.